8000 tracee-rules: refactor non used code by josedonizetti · Pull Request #939 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

tracee-rules: refactor non used code #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2021
Merged

tracee-rules: refactor non used code #939

merged 1 commit into from
Aug 23, 2021

Conversation

josedonizetti
Copy link
Contributor
@josedonizetti josedonizetti commented Aug 19, 2021 •
edited
Loading

This code probably made sense at some point, but it doesn't anymore. The test for an empty event source returns err, but all the calls before check if err != nil { return err}, so if somehow the code entered inside the if it would return nil. But it doesn't seem like that inputs will be empty, it will either have a source or return error

@grantseltzer grantseltzer self-requested a review August 23, 2021 15:10
@grantseltzer
Copy link
Contributor
grantseltzer commented Aug 23, 2021 •
edited
Loading

Makes sense, looks like it used to be more useful 0e5c733

@grantseltzer grantseltzer merged commit b644fe8 into aquasecurity:main Aug 23, 2021
@josedonizetti josedonizetti deleted the tracee-rules-cleanup branch August 23, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantseltzer grantseltzer grantseltzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josedonizetti @grantseltzer
0