8000 chore(ci): revisit PR verification workflow by danielpacak · Pull Request #1252 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(ci): revisit PR verification workflow #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2021
Merged

chore(ci): revisit PR verification workflow #1252

merged 1 commit into from
Dec 16, 2021

Conversation

danielpacak
Copy link
Contributor
@danielpacak danielpacak commented Dec 14, 2021 •
edited
Loading

pr_workflow

The goal of this PR is to revisit PR validation workflow. In particular:

  • Don't run redundant Make targets
  • Run certain jobs in parallel
  • Define dependencies between jobs (e.g. run expensive "Release Snapshot" job only if unit tests passed)
  • Scan tracee Docker images for vulnerabilities
  • Separate steps that relay on Makefile.one targets to cleanup workflow definition file once we complete migration to Makefile.one (Jobs that we'll eventually delete are prefixed with [DEPRECATED])

Signed-off-by: Daniel Pacak pacak.daniel@gmail.com

@danielpacak danielpacak added this to the stabilization milestone Dec 14, 2021
@danielpacak
chore(ci): revisit PR verification workflow
9ad7395 
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
mtcherni95
mtcherni95 reviewed Dec 14, 2021
View reviewed changes
.github/workflows/pr.yaml
name: PR
on:
pull_request:
branches:
- next
- main
env:
GO_VERSION: "1.16"
Copy link
Contributor
@mtcherni95 mtcherni95 Dec 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simar7 , FYI this PR might impact this one #1084

rafaeldtinoco
rafaeldtinoco approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor
@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the change looks good to me. I'm +1 now but I'd like you to check my comment about "make clean" before the test.

@danielpacak danielpacak merged commit f7ee3be into aquasecurity:main Dec 16, 2021
@danielpacak danielpacak deleted the revisit_pr_workflow branch December 16, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtcherni95 mtcherni95 mtcherni95 left review comments

@rafaeldtinoco rafaeldtinoco rafaeldtinoco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
stabilization
Development

Successfully merging this pull request may close these issues.
3 participants
@danielpacak @rafaeldtinoco @mtcherni95
0