8000 add stats printing to stderr in case of lost events by AsafEitani · Pull Request #1387 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add stats printing to stderr in case of lost events #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 26, 2022
Merged

add stats printing to stderr in case of lost events #1387

merged 3 commits into from
Jan 26, 2022

Conversation

AsafEitani
Copy link
Contributor

Addresses #1386

@AsafEitani AsafEitani self-assigned this Jan 24, 2022
@AsafEitani AsafEitani requested review from yanivagman and danielpacak and removed request for yanivagman January 24, 2022 11:38
yanivagman
yanivagman requested changes Jan 24, 2022
View reviewed changes
Copy link
Collaborator
@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment here: #1386 (comment)

@AsafEitani AsafEitani mentioned this pull request Jan 24, 2022
Closed
@yanivagman yanivagman linked an issue Jan 24, 2022 that may be closed by this pull request
Write tracee-ebpf stats to stderr when output is JSON or GOB #1386
Closed
yanivagman
yanivagman reviewed Jan 25, 2022
View reviewed changes
Copy link
Collaborator
@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just please add a comment describing why we added the check for lost>0 (aquasecurity/libbpfgo#122) so we know why it is there

@yanivagman yanivagman merged commit 59f7609 into aquasecurity:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanivagman yanivagman yanivagman approved these changes

@danielpacak danielpacak Awaiting requested review from danielpacak

Assignees

@AsafEitani AsafEitani

Labels
area/rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write tracee-ebpf stats to stderr when output is JSON or GOB
2 participants
@AsafEitani @yanivagman
0