8000 chore: rename tracee-trainer to tracee-tester by danielpacak · Pull Request #1425 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: rename tracee-trainer to tracee-tester #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2022
Merged

chore: rename tracee-trainer to tracee-tester #1425

merged 1 commit into from
Feb 1, 2022

Conversation

danielpacak
Copy link
Contributor

Adds also manually dispatched GitHub Actions workflow
to publish the aquasec/tracee-tester:latest container
image to DockerHub.

Adds also manually dispatched GitHub Actions workflow
to publish the aquasec/tracee-tester:latest container
image to DockerHub.
@grantseltzer
Copy link
Contributor

What are your thoughts on having this image push to dockerhub with releases instead of manually? I can include it in #1367

@danielpacak
Copy link
Contributor Author
danielpacak commented Feb 1, 2022

What are your thoughts on having this image push to dockerhub with releases instead of manually? I can include it in #1367

We use it internally to test tracee before it's actually released so I'm not sure it's another release artifact that we want to publish. What's more, it has a different purpose and life-cycle, i.e. probably we won't change it that often. On the other hand, we may need new version of tracee-tester before we actually release tracee.

The main idea to publish tracee-tester to DockerHub was to speed up and simplify PR validation workflow and avoid rebuilding this image over and over again.

Copy link
Contributor
@grantseltzer grantseltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

run: |
docker image build --tag ${{ github.event.inputs.tag }} tests/tracee-tester
- name: Login to docker.io registry
uses: docker/login-action@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should be using this in the release workflow 👍

@danielpacak danielpacak merged commit 3e418b4 into aquasecurity:main Feb 1, 2022
@danielpacak danielpacak deleted the refactor_tracee-trainer_to_tracee-tester branch February 1, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0