8000 refactor: pkg/cgroup and pkg/containers initial structure by rafaeldtinoco · Pull Request #2350 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: pkg/cgroup and pkg/containers initial structure #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2022
Merged

refactor: pkg/cgroup and pkg/containers initial structure #2350

merged 1 commit into from
Nov 9, 2022

Conversation

rafaeldtinoco
Copy link
Contributor

Description (git log)

Moving code to be reused (and refactored/improved in subsequent PRs). Parts of this code will change with #2233 and it is a spin off from the reactors made by that PR.

Type of change

  • Bug fix (non-breaking change fixing an issue, preferable).
  • Quick fix (minor non-breaking change requiring no issue, use with care)
  • Code refactor (code improvement and/or code removal)
  • New feature (non-breaking change adding functionality).
  • Breaking change (cause existing functionality not to work as expected).

Final Checklist:

Pick "Bug Fix" or "Feature", delete the other and mark appropriate checks.

  • I have made corresponding changes to the documentation.
  • My code follows the style guidelines (C and Go) of this project.
  • I have performed a self-review of my own code.
  • I have commented all functions/methods created explaining what they do.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix, or feature, is effective.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published before.

Git Log Checklist:

My commits logs have:

  • Subject starts with "subsystem|file: description".
  • Do not end the subject line with a period.
  • Limit the subject line to 50 characters.
  • Separate subject from body with a blank line.
  • Use the imperative mood in the subject line.
  • Wrap the body at 72 characters.
  • Use the body to explain what and why instead of how.

@rafaeldtinoco rafaeldtinoco merged commit bd6056b into aquasecurity:main Nov 9, 2022
@rafaeldtinoco rafaeldtinoco deleted the cgroup-mount-refactor branch November 9, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josedonizetti josedonizetti josedonizetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaeldtinoco @josedonizetti
0