8000 Embed test script and import environment variable by grantseltzer · Pull Request #2366 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Embed test script and import environment variable #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2022
Merged

Embed test script and import environment variable #2366

merged 2 commits into from
Dec 5, 2022

Conversation

grantseltzer
Copy link
Contributor

Initial Checklist

  • There is an issue describing the need for this PR.
  • Git log contains summary of the change.
  • Git log contains motivation and context of the change.
  • If part of an EPIC, PR git log contains EPIC number.
  • If part of an EPIC, PR was added to EPIC description.

Description (git log)

commit 8d58970 (HEAD -> integration-test-script-fixes, pfork/integration-test-script-fixes)
Author: grantseltzer grantseltzer@gmail.com
Date: Fri Nov 18 11:09:11 2022 -0500

Embed test script and import environment variable

Signed-off-by: grantseltzer <grantseltzer@gmail.com>

Fixes: #2330 #2331

Type of change

  • Bug fix (non-breaking change fixing an issue, preferable).
  • Quick fix (minor non-breaking change requiring no issue, use with care)
  • Code refactor (code improvement and/or code removal)
  • New feature (non-breaking change adding functionality).
  • Breaking change (cause existing functionality not to work as expected).

How Has This Been Tested?

Compile integration tests and run

Final Checklist:

Pick "Bug Fix" or "Feature", delete the other and mark appropriate checks.

  • I have made corresponding changes to the documentation.
  • My code follows the style guidelines (C and Go) of this project.
  • I have performed a self-review of my own code.
  • I have commented all functions/methods created explaining what they do.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix, or feature, is effective.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published before.

Git Log Checklist:

My commits logs have:

  • Subject starts with "subsystem|file: description".
  • Do not end the subject line with a period.
  • Limit the subject line to 50 characters.
  • Separate subject from body with a blank line.
  • Use the imperative mood in the subject line.
  • Wrap the body at 72 characters.
  • Use the body to explain what and why instead of how.

@grantseltzer
Embed test script and import environment variable
8d58970 
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
@grantseltzer
Copy link
Contributor Author

@06kellyjac Can you take a look at this?

@06kellyjac
Copy link
Contributor

Looks good at a glance.

I'll try it out in my builds soonish

@grantseltzer
Copy link
Contributor Author

I think I need to chmod the script

@grantseltzer grantseltzer force-pushed the integration-test-script-fixes branch 3 times, most recently from ec1ad26 to 3a222f4 Compare November 30, 2022 20:03
@grantseltzer
Chmod +x the test script
4c551fc 
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
@grantseltzer grantseltzer force-pushed the integration-test-script-fixes branch from 3a222f4 to 4c551fc Compare November 30, 2022 20:55
yanivagman
yanivagman approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator
@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanivagman yanivagman merged commit de57aa4 into aquasecurity:main Dec 5, 2022
@yanivagman yanivagman mentioned this pull request Dec 5, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanivagman yanivagman yanivagman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Embed the tester.sh integration test script
4 participants
@grantseltzer @06kellyjac @yanivagman @rafaeldtinoco
0