8000 types: add network protocol events types by rafaeldtinoco · Pull Request #2378 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

types: add network protocol events types #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2022
Merged

types: add network protocol events types #2378

merged 1 commit into from
Nov 29, 2022

Conversation

rafaeldtinoco
Copy link
Contributor

Description (git log)

There are the types used for the new network code at #2200

Type of change

  • Bug fix (non-breaking change fixing an issue, preferable).
  • Quick fix (minor non-breaking change requiring no issue, use with care)
  • Code refactor (code improvement and/or code removal)
  • New feature (non-breaking change adding functionality).
  • Breaking change (cause existing functionality not to work as expected).

@rafaeldtinoco
Copy link
Contributor Author

In order to merge #2200, I need this one merged first and that PR changed to use the new types.

@rafaeldtinoco rafaeldtinoco mentioned this pull request Nov 24, 2022
Merged
33 tasks
@rafaeldtinoco rafaeldtinoco added this to the v0.10.0 milestone Nov 24, 2022
yanivagman
yanivagman reviewed Nov 27, 2022
View reviewed changes
Copy link
Collaborator
@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why not to put these new types under network_trace.go?

@rafaeldtinoco
< 8000 /path> Copy link
Contributor Author

Any reason why not to put these new types under network_trace.go?

Nope. I can make that change.

yanivagman
yanivagman approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator
@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeldtinoco rafaeldtinoco merged commit 39cca7d into aquasecurity:main Nov 29, 2022
@rafaeldtinoco rafaeldtinoco deleted the network-types-only branch November 29, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanivagman yanivagman yanivagman approved these changes

Assignees
No one assigned
Labels
area/network
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaeldtinoco @yanivagman
0