10000 pkg/utils/sharedobjs: check open failure by AlonZivony · Pull Request #2450 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

pkg/utils/sharedobjs: check open failure #2450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2022
Merged

pkg/utils/sharedobjs: check open failure #2450

merged 1 commit into from
Dec 7, 2022

Conversation

AlonZivony
Copy link
Contributor
@AlonZivony AlonZivony commented Dec 7, 2022 •
edited
Loading

Initial Checklist

  • There is an issue describing the need for this PR.
  • Git log contains summary of the change.
  • Git log contains motivation and context of the change.
  • If part of an EPIC, PR git log contains EPIC number.
  • If part of an EPIC, PR was added to EPIC description.

Description (git log)

When changed the capabilities package usage, we didn't check capabilities callback return value (error).
This caused usage of open-failed files, which meant null pointer dereference.

Fixes: #2442

Type of change

  • Bug fix (non-breaking change fixing an issue, preferable).
  • Quick fix (minor non-breaking change requiring no issue, use with care)
  • Code refactor (code improvement and/or code removal)
  • New feature (non-breaking change adding functionality).
  • Breaking change (cause existing functionality not to work as expected).

Final Checklist:

Pick "Bug Fix" or "Feature", delete the other and mark appropriate checks.

  • I have made corresponding changes to the documentation.
  • My code follows the style guidelines (C and Go) of this project.
  • I have performed a self-review of my own code.
  • I have commented all functions/methods created explaining what they do.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix, or feature, is effective.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published before.

Git Log Checklist:

My commits logs have:

  • Subject starts with "subsystem|file: description".
  • Do not end the subject line with a period.
  • Limit the subject 8000 line to 50 characters.
  • Separate subject from body with a blank line.
  • Use the imperative mood in the subject line.
  • Wrap the body at 72 characters.
  • Use the body to explain what and why instead of how.

@AlonZivony AlonZivony marked this pull request as ready for review December 7, 2022 14:29
@AlonZivony
pkg/utils/sharedobjs: check open failure
6d1fff5 
When changed the capabilities package usage, we didn't check
capabilities callback return value (error).
This caused usage of open-failed files, which meant null pointer
dereference.
@AlonZivony AlonZivony force-pushed the bugfix/use-unopened-file-so-loader branch from c97845c to 6d1fff5 Compare December 7, 2022 14:34
yanivagman
yanivagman approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator
@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

8000
@yanivagman yanivagman merged commit 6c47738 into aquasecurity:main Dec 7, 2022
@AlonZivony AlonZivony deleted the bugfix/use-unopened-file-so-loader branch December 8, 2022 09:36
@rafaeldtinoco rafaeldtinoco mentioned this pull request Dec 15, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josedonizetti josedonizetti josedonizetti approved these changes

@yanivagman yanivagman yanivagman approved these changes

@rafaeldtinoco rafaeldtinoco Awaiting requested review from rafaeldtinoco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] crash due to nil pointer dereference in loadSharedObjectDynamicSymbols in v0.9.3
3 participants
@AlonZivony @josedonizetti @yanivagman
0