Add multiple printers #2746
Merged
Add multiple printers #2746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5678262 to
e9b169a
Compare
e9b169a to
63d6cfa
Compare
geyslan
reviewed
Feb 22, 2023
3571116 to
a0cf505
Compare
yanivagman
reviewed
Feb 23, 2023
pkg/cmd/flags/output.go
Outdated
Comment on lines
25
to
30
| Log options: | ||
| log-file:/path/to/file write the logs to a specified file. create/trim the file if exists (default: stderr) |
There was a problem hiding this comment.
log options should probably move to the --log flag
There was a problem hiding this comment.
I like it, will create an issue for it.
311659e to
77167f7
Compare
77167f7 to
cc16da4
Compare
geyslan
requested changes
Feb 23, 2023
cc16da4 to
a11127a
Compare
geyslan
approved these changes
Feb 24, 2023
yanivagman
approved these changes
Feb 26, 2023
There was a problem hiding this comment.
Nice work @josedonizetti !
Overall LGTM, some nit comments ahead
|
Make sure to rebase so #2776 is included and new testers are used. |
The output flag will be different depending on the binary. This commit is renaming the output based on the binary that will use it, tracee-ebpf.
a11127a to
f5e77c4
Compare
f5e77c4 to
3b792ef
Compare
|
Thanks for waiting on my review/read. Nice job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
This PR add support for multiple printers to new
traceebinary. The old binarytracee-ebpfmaintain the previous syntax, and the change is only implemented for the new binary, for such I have first created a commit where I rename the previousoutputflag in order to simplify the deletion once we deprecate and removetracee-ebpf.The new syntax was discussed on a previous PR #2709
This PR is part of #2355
Close #2231
2. Explain how to test it
Please check the help commands:
3. Other comments
Multiple printers will be the base of the webhook implementation for the new binary, where webhooks will be a printer like stdout, etc.