adjust recently merged symbols_collision event and better document it #2743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for further changes.
1. containers/path_resolver: return a pointer 2. ebpf/tracee: - cleanup derivation table init function - move symbols_collision initialization to the correct place 3. events/symbols_loaded: - extend init function with code from derivation table init - adjust formatting for readability 4. events/symbols_collision: - extend init function with code from derivation table init - adjust formatting for readability - add comments to explain the logic - rename variables for meaning clarity 5. events/symbols_collision_test: - adjust test to reflect the new init function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit edd80f4 (HEAD -> symbols_coll_refactor, rafaeldtinoco/symbols_coll_refactor, main)
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Sun Feb 19 14:25:27 2023
commit 0fa6ca5
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Sun Feb 19 14:24:25 2023
commit cad2076
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Fri Feb 17 13:41:00 2023
commit 344f100
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Thu Feb 16 22:11:18 2023
commit c931a3e
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Thu Feb 16 22:14:13 2023