8000 flags: cli: docs: rename trace flag to filter by geyslan · Pull Request #2767 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

flags: cli: docs: rename trace flag to filter #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2023
Merged

flags: cli: docs: rename trace flag to filter #2767

merged 1 commit into from
Feb 28, 2023

Conversation

geyslan
Copy link
Member
@geyslan geyslan commented Feb 23, 2023 •
edited
Loading

Fixes: #2751

1. Explain what the PR does

flags: cli: docs: rename trace flag to filter

This is a breaking change, but it is necessary to provide a more
consistent user experience.

The flag is now called --filter, and the docs are updated to reflect
the new name.

2. Explain how to test it

./dist/tracee --filter help

sudo ./dist/tracee -f container
sudo ./dist/tracee --filter container
sudo ./dist/tracee --filter comm=uname --filter 'pid>0'
...

3. Other comments

  • Breaking Change

@geyslan
flags: cli: docs: rename trace flag to filter
f30d3fe 
This is a breaking change, but it is necessary to provide a more
consistent user experience.

The flag is now called --filter, and the docs are updated to reflect
the new name.
@geyslan geyslan self-assigned this Feb 23, 2023
@geyslan geyslan requested a review from yanivagman February 23, 2023 18:02
@rafaeldtinoco rafaeldtinoco self-requested a review February 23, 2023 18:47
yanivagman
yanivagman approved these changes Feb 26, 2023
View reviewed changes
Copy link
Collaborator
@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan
Copy link
Member Author
geyslan commented Feb 27, 2023

@roikol @AsafEitani this will surely break e2e tests so I'll wait for a signal from your side before merging it.

@rafaeldtinoco
Copy link
Contributor

@geyslan #2776 has merged new testers but, since this already passed the old ones, I think you're good to merge it as you think its appropriate (likely sinking with research like you looked for already).

@AsafEitani
Copy link
Contributor

@roikol @AsafEitani this will surely break e2e tests so I'll wait for a signal from your side before merging it.

@geyslan you can merge, we updated the e2e

@geyslan geyslan merged commit 4b12d44 into aquasecurity:main Feb 28, 2023
@geyslan geyslan deleted the 2571-rename-trace-to-filter branch May 29, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanivagman yanivagman yanivagman approved these changes

@rafaeldtinoco rafaeldtinoco Awaiting requested review from rafaeldtinoco

Assignees

@geyslan geyslan

Labels
area/filtering area/UX kind/chore kind/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename --trace flag to --filter
4 participants
@geyslan @rafaeldtinoco @AsafEitani @yanivagman
0