8000 tracee: make it the default binary by josedonizetti · Pull Request #2777 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

tracee: make it the default binary #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2023
Merged

tracee: make it the default binary #2777

merged 1 commit into from
Feb 28, 2023

Conversation

josedonizetti
Copy link
Contributor
@josedonizetti josedonizetti commented Feb 27, 2023 •
edited
Loading

1. Explain what the PR does

This PR changes docker image entrypoint to use the new tracee binary. It removes the use of the older binaries tracee-ebpf and tracee-rules.

2. Explain how to test it

make -f builder/Makefile.tracee-container build-tracee
docker run  --name tracee --rm -it  --pid=host --cgroupns=host --privileged  -v /etc/os-release:/etc/os-release-host:ro      -e LIBBPFGO_OSRELEASE_FILE=/etc/os-release-host  tracee:latest

# test different options
docker run  --name tracee --rm -it  --pid=host --cgroupns=host --privileged  -v /etc/os-release:/etc/os-release-host:ro      -e LIBBPFGO_OSRELEASE_FILE=/etc/os-release-host  tracee:latest --output json

docker run  --name tracee --rm -it  --pid=host --cgroupns=host --privileged  -v /etc/os-release:/etc/os-release-host:ro      -e LIBBPFGO_OSRELEASE_FILE=/etc/os-release-host  tracee:latest --filter set=signatures

Do the same for the full image.

This is part of #2355

3. Other comments

@rafaeldtinoco
Copy link
Contributor

Any new push will pick the new github testers (FYIO).

@josedonizetti josedonizetti marked this pull request as ready for review February 28, 2023 14:04
@josedonizetti josedonizetti requested review from geyslan, rafaeldtinoco and yanivagman and removed request for geyslan February 28, 2023 14:07
@josedonizetti josedonizetti self-assigned this Feb 28, 2023
geyslan
geyslan approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member
@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

Just some shellcheck caughts.

@yanivagman
Copy link
Collaborator

LGTM

@josedonizetti josedonizetti merged commit 33aecbb into aquasecurity:main Feb 28, 2023
@josedonizetti josedonizetti deleted the make-tracee-default branch February 28, 2023 17:16
rafaeldtinoco
rafaeldtinoco reviewed Feb 28, 2023
View reviewed changes
builder/entrypoint.sh
--output=out-file:${TRACEE_PIPE} &
tracee_ebpf_pid=$!
$@
#tracee_pid=$!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josedonizetti nit: leftover here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Le 8F16 arn more.

Thanks! Fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeldtinoco rafaeldtinoco rafaeldtinoco left review comments

@geyslan geyslan geyslan approved these changes

@yanivagman yanivagman yanivagman approved these changes

Assignees

@josedonizetti josedonizetti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josedonizetti @rafaeldtinoco @yanivagman @geyslan
0