8000 k8s: remove flag everythingIsAnEvent from helm by josedonizetti · Pull Request #2785 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

k8s: remove flag everythingIsAnEvent from helm #2785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2023
Merged

k8s: remove flag everythingIsAnEvent from helm #2785

merged 1 commit into from
Mar 1, 2023

Conversation

josedonizetti
Copy link
Contributor
@josedonizetti josedonizetti commented Mar 1, 2023 •
edited
Loading

This flag was used for users who wanted to try the new experience when it was beta, but the new experience will now be the default option.

1. Explain what the PR does

This PR removes the helm flag everythingIsAnEvent which was used to enable the new experience while it was beta. With the next release this experience will be the default option.

This is part of #2355

2. Explain how to test it

# have a k8s cluster

helm repo add aqua https://aquasecurity.github.io/helm-charts/
helm dependency update ./deploy/helm/tracee
helm install tracee ./deploy/helm/tracee \
        --namespace tracee-system --create-namespace \
        --set hostPID=true

3. Other comments

@josedonizetti
k8s: remove flag everythingIsAnEvent from helm
51a973b 
This flag was used for users who wanted to try the new experience when
it was beta, but the new experience will now be the default option.
@josedonizetti josedonizetti self-assigned this Mar 1, 2023
yanivagman
yanivagman reviewed Mar 1, 2023
View reviewed changes
deploy/helm/tracee/templates/daemonset.yaml
command: ["/tracee/tracee"]
args:
- --output
- json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we still need to set the output as json?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was all under the flag, which we are removing here. For the new binary, several things will change, and they are handled on the PR #2786

rafaeldtinoco
rafaeldtinoco approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor
@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josedonizetti josedonizetti merged commit 1dddf8d into aquasecurity:main Mar 1, 2023
@josedonizetti josedonizetti deleted the remove-flag-everything-is-an-event branch March 1, 2023 13:44
geyslan
geyslan reviewed Mar 1, 2023
View reviewed changes
Copy link
Member
@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geyslan geyslan geyslan left review comments

@rafaeldtinoco rafaeldtinoco rafaeldtinoco approved these changes

@yanivagman yanivagman yanivagman approved these changes

Assignees

@josedonizetti josedonizetti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josedonizetti @geyslan @rafaeldtinoco @yanivagman
0