8000 check relevant error returns by geyslan · Pull Request #2818 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

check relevant error returns #2818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2023
Merged

check relevant error returns #2818

merged 3 commits into from
Mar 21, 2023

Conversation

geyslan
Copy link
Member
@geyslan geyslan commented Mar 6, 2023 •
edited
Loading

1. Explain what the PR does

Fix: #2477

commit 6421448

builder: add staticcheck to dockerfiles

commit f511c82

cleanup: check relevant return errors

commit 2bf32fc

tool: add errcheck

Introduce `make check-err` rule and fix doc renaming `make code-check`
to `make check-code`.

2. Explain how to test it

make test-unit
sudo make test-integration

3. Other comments

Context:

Part of effort:

@geyslan geyslan self-assigned this Mar 6, 2023
@geyslan geyslan force-pushed the 2477-check-err-returns branch from d627aca to b6d0ff4 Compare March 6, 2023 21:12
@geyslan geyslan mentioned this pull request Mar 6, 2023
Closed
9 tasks
@geyslan geyslan force-pushed the 2477-check-err-returns branch 2 times, most recently from 3a8ad9a to 63f8b80 Compare March 7, 2023 14:14
@yanivagman yanivagman self-requested a review March 7, 2023 16:49
@yanivagman
Copy link
Collaborator

I would like to review this before merge

@geyslan geyslan force-pushed the 2477-check-err-returns branch from 63f8b80 to 54d9f79 Compare March 7, 2023 17:41
@aqua-ci

This comment was marked as spam.

Sign in to view
@geyslan geyslan force-pushed the 2477-check-err-returns branch 2 times, most recently from d8437fd to 1b95b4d Compare March 15, 2023 11:36
@geyslan
Copy link
Member Author
geyslan commented Mar 15, 2023

@yanivagman rebased and ready for review.

geyslan added 3 commits March 16, 2023 12:12
@geyslan
tool: add errcheck
2bf32fc 
Introduce `make check-err` rule and fix doc renaming `make code-check`
to `make check-code`.
@geyslan
cleanup: check relevant return errors
f511c82
@geyslan
builder: add staticcheck to dockerfiles
6421448
@geyslan geyslan force-pushed the 2477-check-err-returns branch from 1b95b4d to 6421448 Compare March 16, 2023 16:22
@aqua-ci
Copy link
aqua-ci commented Mar 16, 2023

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0f12d300b01df6d27_2818-4439293164_arm64' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link
aqua-ci commented Mar 16, 2023

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0f12d300b01df6d27_2818-4439293164_arm64c' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link
aqua-ci commented Mar 16, 2023

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0d40904002284d8de_2818-4439293164_arm64' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link
aqua-ci commented Mar 16, 2023

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0f23165db12015479_2818-4439293164_x64' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link
aqua-ci commented Mar 16, 2023

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0f23165db12015479_2818-4439293164_x64c' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link
aqua-ci commented Mar 16, 2023

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0d40904002284d8de_2818-4439293164_arm64c' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link
aqua-ci commented Mar 16, 2023

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0f14a28ff0b2d6279_2818-4439293164_x64' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link
aqua-ci commented Mar 16, 2023

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0f14a28ff0b2d6279_2818-4439293164_x64c' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

yanivagman
yanivagman approved these changes Mar 18, 2023
View reviewed changes
Copy link
Collaborator
@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small clarification question, otherwise LGTM

@rafaeldtinoco
Copy link
Contributor

@geyslan make sure to run E2E tests BEFORE merging this one as the error handling, despite being correct, might introduce issues here and there (despite also the fact that in most cases you're just logging, which should be fine).

@geyslan
Copy link
Member Author
geyslan commented Mar 20, 2023

This hasn't been merged yet as I'm not getting e2e tests to verify this PR. Check out run 685 and comments I put on its result.

@yanivagman yanivagman merged commit ffddb99 into aquasecurity:main Mar 21, 2023
@geyslan geyslan deleted the 2477-check-err-returns branch May 29, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanivagman yanivagman yanivagman approved these changes

Assignees

@geyslan geyslan

Labels
area/build area/ebpf area/events area/filtering area/signatures area/testing area/UX kind/chore kind/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracee code cleanup
4 participants
@geyslan @yanivagman @aqua-ci @rafaeldtinoco
0