8000 errfmt: introduce new package for error formatting by geyslan · Pull Request #2842 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

errfmt: introduce new package for error formatting #2842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2023
Merged

errfmt: introduce new package for error formatting #2842

merged 2 commits into from
Mar 14, 2023

Conversation

geyslan
Copy link
Member
@geyslan geyslan commented Mar 9, 2023 •
edited
Loading

1. Explain what the PR does

commit 69d1a2a

errfmt: refactor to use pkg/errfmt

commit 52d176c

errfmt: introduce new package for error formatting

This commit introduces a new error-formatting package, moving and
re-factoring existing error-formatting code from the logger package
into it.

Fixes: #2783

2. Explain how to test it

3. Other comments

8000
@geyslan geyslan self-assigned this Mar 9, 2023
@geyslan geyslan force-pushed the 2783-errs-pkg branch 2 times, most recently from 386e747 to a627004 Compare March 9, 2023 15:21
@geyslan
Copy link
Member Author
geyslan commented Mar 9, 2023

[ERROR] GitHub self host service failed connecting to GitHub. Infrastrcuture team has been updated as wel, please hold until investigation.

Those spawned when I cancelled checks workflow.

@geyslan
Copy link
Member Author
geyslan commented Mar 9, 2023

[ERROR] GitHub self host service failed connecting to GitHub. Infrastrcuture team has been updated as wel, please hold until investigation.

@rafaeldtinoco could this message be related to this warning?

image

@rafaeldtinoco
Copy link
Contributor

@rafaeldtinoco could this message be related to this warning?

Nope. I have warned devops already about the spam (independently of an error, there shouldn't be a spam like that in public issues). They always check the other errors, so its just a question of retrying from our side (and let them review the errors whenever they can).

NDStrahilevitz
NDStrahilevitz reviewed Mar 14, 2023
View reviewed changes
@aquasecurity aquasecurity deleted a comment from aqua-ci Mar 14, 2023
@aquasecurity aquasecurity deleted a comment from aqua-ci Mar 14, 2023
@aquasecurity aquasecurity deleted a comment from aqua-ci Mar 14, 2023
@aquasecurity aquasecurity deleted a comment from aqua-ci Mar 14, 2023
@aquasecurity aquasecurity deleted a comment from aqua-ci Mar 14, 2023
@aquasecurity aquasecurity deleted a comment from aqua-ci Mar 14, 2023
@aquasecurity aquasecurity deleted a comment from aqua-ci Mar 14, 2023
@aquasecurity aquasecurity deleted a comment from aqua-ci Mar 14, 2023
@aquasecurity aquasecurity deleted a comment from aqua-ci Mar 14, 2023
@aquasecurity aquasecurity deleted a comment from aqua-ci Mar 14, 2023
@aquasecurity aquasecurity deleted a comment from aqua-ci Mar 14, 2023
@aquasecurity aquasecurity deleted a comment from aqua-ci Mar 14, 2023
@aquasecurity aquasecurity deleted a comment from aqua-ci Mar 14, 2023
@aquasecurity aquasecurity deleted a comment from aqua-ci Mar 14, 2023
@aquasecurity aquasecurity deleted a comment from aqua-ci Mar 14, 2023
@aquasecurity aquasecurity deleted a comment from aqua-ci Mar 14, 2023
@aquasecurity aquasecurity deleted a comment from aqua-ci Mar 14, 2023
@rafaeldtinoco rafaeldtinoco self-requested a review March 14, 2023 19:29
rafaeldtinoco
rafaeldtinoco suggested changes Mar 14, 2023
View reviewed changes
Copy link
Contributor
@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geyslan could u rename the pkg then ? Tks!

geyslan added 2 commits March 14, 2023 17:03
@geyslan
errfmt: introduce new package for error formatting
52d176c 
This commit introduces a new error-formatting package, moving and
re-factoring existing error-formatting code from the logger package
into it.
@geyslan
errfmt: refactor to use pkg/errfmt
69d1a2a
@geyslan geyslan changed the title errs: introduce new package for error handling errfmt: introduce new package for error formatting Mar 14, 2023
@geyslan
Copy link
Member Author
geyslan commented Mar 14, 2023

@geyslan could u rename the pkg then ? Tks!

Done.

@rafaeldtinoco rafaeldtinoco self-requested a review March 14, 2023 20:09
@rafaeldtinoco rafaeldtinoco merged commit a04d8e7 into aquasecurity:main Mar 14, 2023
@geyslan geyslan deleted the 2783-errs-pkg branch May 29, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NDStrahilevitz NDStrahilevitz NDStrahilevitz left review comments

@rafaeldtinoco rafaeldtinoco rafaeldtinoco approved these changes

Assignees

@geyslan geyslan

Labels
kind/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor logger.{NewErrorf,ErrorFunc}
3 participants
@geyslan @rafaeldtinoco @NDStrahilevitz
0