Policy number CLI removal #2919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b31adf0 to
361ea5e
Compare
This was referenced Mar 24, 2023
Closed
Merged
This must be re-enabled in the future based on policy file mechanism.
361ea5e to
0595788
Compare
josedonizetti
approved these changes
Mar 28, 2023
|
@yanivagman @josedonizetti Once the tests pass, I'll merge this and tackle the integration test for policy file loading (few cases). |
yanivagman
reviewed
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Removes policy number CLI in favor of policy files mechanism #2892.
2. Explain how to test it
3. Other comments
This will be rebased once #2892 is merged.
Fixes: #2918