8000 types: event policy name by geyslan · Pull Request #2922 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

types: event policy name #2922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2023
Merged

types: event policy name #2922

merged 1 commit into from
Mar 28, 2023

Conversation

geyslan
Copy link
Member
@geyslan geyslan commented Mar 27, 2023 •
edited
Loading

1. Explain what the PR does

This adds the MatchedPoliciesNames field to the event struct. This field will be used to store the name of the policy that matched the event.

It also omits the MatchedPolicies bitmask from the event struct marshalling.

2. Explain how to test it

3. Other comments

This is required by #2923

@geyslan
types: event policy name
f8712b7 
This adds the MatchedPoliciesNames field to the event struct. This field
will be used to store the name of the policy that matched the event.

It also omits the MatchedPolicies bitmask from the event struct
marshalling.
@geyslan geyslan requested a review from josedonizetti March 27, 2023 16:28
@geyslan geyslan mentioned this pull request Mar 27, 2023
Merged
@geyslan geyslan marked this pull request as ready for review March 27, 2023 16:29
@geyslan geyslan requested a review from yanivagman March 27, 2023 16:32
@geyslan geyslan mentioned this pull request Mar 27, 2023
Closed
10 tasks
@aqua-ci
Copy link
aqua-ci commented Mar 27, 2023

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0ffd52e93f1a0370b_2922-4534308732_arm64c' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link
aqua-ci 8000 commented Mar 27, 2023

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0d40904002284d8de_2922-4534308732_arm64c' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

yanivagman
yanivagman approved these changes Mar 27, 2023
View reviewed changes
Copy link
Collaborator
@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan
Copy link
Member Author
geyslan commented Mar 27, 2023

Waiting e2e fix due to recent type changes, as reported in e2e test 705.

@yanivagman yanivagman merged commit cb54a2c into aquasecurity:main Mar 28, 2023
@geyslan geyslan deleted the types-policy-name branch May 29, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josedonizetti josedonizetti josedonizetti approved these changes

@yanivagman yanivagman yanivagman approved these changes

Assignees

@geyslan geyslan

Labels
kind/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geyslan @aqua-ci @josedonizetti @yanivagman
0