performance: introduce automated performance dashboard with pyroscope #2968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Developer might execute: - make -f builder/Makefile.performance pyroscope-start - make -f builder/Makefile.performance pyroscope-stop And will get access to a performance dashboard while executing tracee.
| @@ -85,6 +87,20 @@ func (s *Server) EnablePProfEndpoint() { | |||
| s.mux.HandleFunc("/debug/pprof/trace", pprof.Trace) | |||
| } | |||
|
|
|||
| // EnablePyroAgent enables pyroscope agent in golang push mode | |||
| // TODO: make this configurable | |||
| func (s *Server) EnablePyroAgent() error { | |||
There was a problem hiding this comment.
IIRC pyroscope should be able to directly scrape pprof and as I can see in the prometheus.yml file you do target the default :3366 port.
And in another file I see you target this port, so i'm not sure what's the difference.
There was a problem hiding this comment.
We already covered that in private. More performatic and I also couldn't do the "pull mode" (which is what you are referring) to work in an automated way: https://pyroscope.io/docs/golang-pull-mode/.
I'll give another try, but not a blocker as we've spoken.
NDStrahilevitz
approved these changes
Apr 3, 2023
|
@josedonizetti waiting for you before merging or can we go ahead? |
|
Adding to milestone 0.13.1 as this is not a code change and allows us to test Tracee better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Tracee developers are struggling to find different ways to check performance results when doing the development. This is an attempt to automate performance checks and dashboards in order for an unified experience.
This first feature adds a grafana dash board containing trace pperf
commit bb367ac (HEAD -> new-pyro, rafaeldtinoco/new-pyro)
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Mon Apr 3 06:09:03 2023
commit b3382a5
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Mon Apr 3 06:08:22 2023
2. Explain how to test it
3. Other comments
Idea is to make the dashboard better with time: