logger: refactor logger configuration #2971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the option for configuring the logger from environemnt variables in favor of programmatic configuration. This further exposes the option of supplying your own logger implementation and replacing tracee's default implemenation for library consumers of tracee. Clean up the package to separate files for the utilities (log counters and caller info).
a8873aa to
ef90ed0
Compare
Since moving to new the new AMI testing infrastructure, the machines running the integration tests do not have the alpine image pulled before running the tests. As such we may miss the container id of the alpine container in do_docker_run because docker pulls the image first, which causes the expected id to be empty. Add a docker pull alpine call beforehand to resolve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the option for configuring the logger from environemnt variables in favor of programmatic configuration.
This further exposes the option of supplying your own logger implementation and replacing tracee's default implemenation for library consumers of tracee.
Clean up the package to separate files for the utilities (log counters and caller info).
Fix #2475