8000 fix: add file to error message when parsing yaml by josedonizetti · Pull Request #2995 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add file to error message when parsing yaml #2995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2023
Merged

fix: add file to error message when parsing yaml #2995

merged 1 commit into from
Apr 11, 2023

Conversation

josedonizetti
Copy link
Contributor

1. Explain what the PR does

Improve error message, adding the file which is failing the parsing:

before:

{"level":"fatal","ts":1681236515.5112734,"msg":"App","error":"yaml: line 5: found character that cannot start any token"}

after:

{"level":"fatal","ts":1681236535.9763668,"msg":"App","error":"urfave.getPoliciesFromFile: error parsing /home/josedonizetti/code/aquasecurity/tracee-action/policies/file_writes.yaml: yaml: line 5: found character that cannot start any token"}

2. Explain how to test it

3. Other comments

@josedonizetti josedonizetti requested a review from geyslan April 11, 2023 18:16
rafaeldtinoco
rafaeldtinoco approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor
@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josedonizetti josedonizetti merged commit 1a971fb into aquasecurity:main Apr 11, 2023
@josedonizetti josedonizetti deleted the fix-error-message-parsing-yaml branch April 11, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeldtinoco rafaeldtinoco rafaeldtinoco approved these changes

@geyslan geyslan Awaiting requested review from geyslan

Assignees

@josedonizetti josedonizetti

Labels
area/policies area/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josedonizetti @rafaeldtinoco
0