ebpf: non non-core. building files. #3015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanivagman
reviewed
Apr 24, 2023
This comment was marked as outdated.
This comment was marked as outdated.
yanivagman
requested changes
Apr 27, 2023
There was a problem hiding this comment.
Let's avoid renaming files in this PR (done in the last commit).
I disagree with some of these renamings (e.g. common->include and splitting kernel and tracee), yet I think we should merge the other commits.
We can discuss further changes in the next milestone.
yanivagman
reviewed
Apr 27, 2023
yanivagman
reviewed
Apr 27, 2023
yanivagman
reviewed
Apr 27, 2023
yanivagman
reviewed
Apr 27, 2023
yanivagman
reviewed
Apr 27, 2023
|
Please, let's defer the last commit to another PR |
|
Okay I think this is "ready" to be merged IMO (unless there are other issues to be addressed that I couldn't spot). Let me know WYT. Thank you. |
8000
yanivagman
reviewed
Apr 28, 2023
squash with ebpf
- keep external BTF file logic
Current eBPF source headers have several problems: - some of them use local headers "", some the search path <> - clangd wasn't able to index headers correctly Follow: #2359 for TODOs NO CHANGES BUT POSITIONAL AND INCLUDE FIXES.
yanivagman
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to split the eBPF code into multiple eBPF objects and include the logic to load them depending on the events being traced, for example. But I think as an initial step we should drop non CORE, clean up the code a bit for readability and styling, and do that soon/later.
I'll try to enforce a code styling through some formatter (as we have many developers and each one seems to be doing a different style currently, even with clang-format trying to enforce some rules).
I have removed all NON CORE related code (AFAICT) and changed Makefiles, Dockerfiles and Workflows appropriately. Let's test here and then with our internal E2E tests to see how things go.
This PR might impact other PRs touching eBPF code, but, still, easy to rebase as there are no logic changes, just positional/styling changes mostly.
commit 829adfe (HEAD -> drop-noncore, rafaeldtinoco/drop-noncore)
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Wed Apr 26 01:02:57 2023
commit 239768b (test)
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Tue Apr 25 23:24:11 2023
commit 380a1e1
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Mon Apr 24 17:41:39 2023
commit f7da045
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Mon Apr 24 11:40:10 2023
commit 467da62
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Mon Apr 24 18:28:51 2023