fix for kernels v6.3 and mitigation for tracee.pid in tests #3076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2023
|
This is ready for review. The only thing having errors in v6.1 and v6.3 kernels is the e2e instrumentation tests for file_modification event (opened #3077 for that issue). I don't see why not merging this one (if you agree) because then the tests will get fixed once that PR is merged (hopefully). |
|
I have opened an issue for the failing tests. All the rest (in this PR) is good. |
yanivagman
reviewed
May 9, 2023
Updating urfave brought some issues with cmdline parsing. Usually we would fix them but, since urfave is being deprecated, it is just easier to keep urfave version until then. Fixes broken "magic_write_filter" parsing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit cea89a6 (HEAD -> include-v6, rafaeldtinoco/include-v6)
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Mon May 8 23:45:33 2023
commit f45cc1b
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Mon May 8 23:42:07 2023
commit 5752060
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Mon May 8 12:54:31 2023
commit 6aee729
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Mon May 8 12:53:06 2023
The only change that isn't chore is the change that fixes v6.3 kernels (commit f45cc1b) and the way to test it:
test case
in a v6.3.1 kernel (vanilla upstream)
{"timestamp":1683599572209837155,"threadStartTime":1683599572207592072,"processorId":12,"processId":1645572,"cgroupId":6255,"threadId":1645572,"parentProcessId":1645571,"hostProcessId":1645572,"hostThreadId":1645572,"hostParentProcessId":1645571,"userId":0,"mountNamespace":4026531841,"pidNamespace":4026531836,"processName":"capsh","hostName":"fujitsu","container":{},"kubernetes":{},"eventId":"723","eventName":"commit_creds","matchedPolicies":[""],"argsNum":2,"returnValue":0,"syscall":"prctl","stackAddresses":null,"contextFlags":{"containerStarted":false,"isCompat":false},"args":[{"name":"old_cred","type":"slim_cred_t","value":{"Uid":0,"Gid":0,"Suid":0,"Sgid":0,"Euid":0,"Egid":0,"Fsuid":0,"Fsgid":0,"UserNamespace":4026531837,"SecureBits":0,"CapInheritable":0,"CapPermitted":2199023255551,"CapEffective":2199023255551,"CapBounding":2199023255551,"CapAmbient":0}},{"name":"new_cred","type":"slim_cred_t","value":{"Uid":0,"Gid":0,"Suid":0,"Sgid":0,"Euid":0,"Egid":0,"Fsuid":0,"Fsgid":0,"UserNamespace":4026531837,"SecureBits":0,"CapInheritable":0,"CapPermitted":2199023255551,"CapEffective":2199023255551,"CapBounding":2199021158399,"CapAmbient":0}}]}in a 5.15.0-69-generic kernel (ubuntu flavored)
{"timestamp":1683599381252829883,"threadStartTime":1683599381250171936,"processorId":5,"processId":2981,"cgroupId":4098,"threadId":2981,"parentProcessId":2980,"hostProcessId":2981,"hostThreadId":2981,"hostParentProcessId":2980,"userId":0,"mountNamespace":4026531841,"pidNamespace":4026531836,"processName":"capsh","hostName":"e2etests","container":{},"kubernetes":{},"eventId":"723","eventName":"commit_creds","matchedPolicies":[""],"argsNum":2,"returnValue":0,"syscall":"prctl","stackAddresses":null,"contextFlags":{"containerStarted":false,"isCompat":false},"args":[{"name":"old_cred","type":"slim_cred_t","value":{"Uid":0,"Gid":0,"Suid":0,"Sgid":0,"Euid":0,"Egid":0,"Fsuid":0,"Fsgid":0,"UserNamespace":4026531837,"SecureBits":0,"CapInheritable":0,"CapPermitted":2199023255551,"CapEffective":2199023255551,"CapBounding":2199023255551,"CapAmbient":0}},{"name":"new_cred","type":"slim_cred_t","value":{"Uid":0,"Gid":0,"Suid":0,"Sgid":0,"Euid":0,"Egid":0,"Fsuid":0,"Fsgid":0,"UserNamespace":4026531837,"SecureBits":0,"CapInheritable":0,"CapPermitted":2199023255551,"CapEffective":2199023255551,"CapBounding":2199021158399,"CapAmbient":0}}]}