8000 Fix logger by josedonizetti · Pull Request #3092 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix logger #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 12, 2023
Merged

Fix logger #3092

merged 3 commits into from
May 12, 2023

Conversation

josedonizetti
Copy link
Contributor
@josedonizetti josedonizetti commented May 10, 2023 •
edited
Loading

1. Explain what the PR does

The logger should be the first thing to initialize, as we have packages using it already, like: https://github.com/aquasecurity/tracee/blob/main/pkg/signatures/signature/signature.go#L23

There is also two simple commits to remove an old TODO, and clean up an if not used.

2. Explain how to test it

3. Other comments

@josedonizetti josedonizetti requested a review from yanivagman May 12, 2023 19:24
rafaeldtinoco
rafaeldtinoco approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor
@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeldtinoco rafaeldtinoco merged commit ea3244a into aquasecurity:main May 12, 2023
@josedonizetti josedonizetti deleted the fix-logger branch May 12, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeldtinoco rafaeldtinoco rafaeldtinoco approved these changes

@yanivagman yanivagman Awaiting requested review from yanivagman

Assignees

@josedonizetti josedonizetti

Labels
area/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josedonizetti @rafaeldtinoco
0