8000 refactor: move PolicyFile to policy pkg by josedonizetti · Pull Request #3125 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: move PolicyFile to policy pkg #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2023
Merged

refactor: move PolicyFile to policy pkg #3125

merged 1 commit into from
May 23, 2023

Conversation

josedonizetti
Copy link
Contributor
@josedonizetti josedonizetti commented May 20, 2023 •
edited
Loading

1. Explain what the PR does

This PR moves PolicyFile to be under the policy package. This allows the validation of policy 
to be done earlier because we validate the Policies now once they are getting read from the filesystem. 
The early validation allows policies use for other purposes like printers, not only the filterMap generation. 
It also removes cycle imports between the pkg flags and printers.

2. Explain how to test it

3. Other comments

This PR is the base for the policy printer #3126.

@josedonizetti josedonizetti force-pushed the refactor-policy-file branch 3 times, most recently from 63811d1 to 672312f Compare May 20, 2023 19:04
@josedonizetti josedonizetti marked this pull request as ready for review May 21, 2023 13:01
@josedonizetti josedonizetti marked this pull request as draft May 21, 2023 13:01
@josedonizetti josedonizetti marked this pull request as ready for review May 21, 2023 13:12
@josedonizetti josedonizetti mentioned this pull request May 21, 2023
Merged
@josedonizetti
refactor: move PolicyFile to policy pkg
66eb74b 
This PR moves PolicyFile to be under the policy package.
This allows to the validation of policy to be done earlier,
because we validate the Policies now once they are getting
read from the filesystem. The early validation allow policies
use for other purposes like printers, not only the filterMap generation.
It also remove cycle imports between the pkg flags and pritners.
@josedonizetti josedonizetti force-pushed the refactor-policy-file branch from 672312f to 66eb74b Compare May 21, 2023 15:26
yanivagman
yanivagman approved these changes May 23, 2023
View reviewed changes
Copy link
Collaborator
@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josedonizetti josedonizetti merged commit 625cbfc into aquasecurity:main May 23, 2023
@josedonizetti josedonizetti deleted the refactor-policy-file branch May 23, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanivagman yanivagman yanivagman approved these changes

Assignees

@josedonizetti josedonizetti

Labels
area/flags area/testing area/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josedonizetti @yanivagman
0