types: change Event fields #3196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geyslan
commented
Jun 1, 2023
Comment on lines
+37
to
+39
| MatchedPoliciesKernel uint64 `json:"-"` | ||
| MatchedPoliciesUser uint64 `json:"-"` | ||
| MatchedPolicies []string `json:"matchedPolicies,omitempty"` |
rafaeldtinoco
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
LGTM. Reviewing #3183 and will propose my changes to that PR so you can rebase that PR on top of this type change and merge that PR with my suggested changes (if you agree). Mostly documenting stuff (and applying the policies+network fix).
"MatchedPolicies" pass to be named "MatchedPoliciesKernel" and propagated through the pipeline without being changed (internal). "MatchedPoliciesUser" is a new bitmask of the policies that matched after applying user land filters through the pipeline (internal). "MatchedPoliciesNames" is now named "MatchedPolicies" (public).
c93ef5e to
93a9ce8
Compare
josedonizetti
approved these changes
Jun 2, 2023
geyslan
added a commit
to geyslan/tracee
that referenced
this pull request
Jun 5, 2023
"MatchedPolicies" pass to be named "MatchedPoliciesKernel" and propagated through the pipeline without being changed (internal). "MatchedPoliciesUser" is a new bitmask of the policies that matched after applying user land filters through the pipeline (internal). "MatchedPoliciesNames" is now named "MatchedPolicies" (public).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
2. Explain how to test it
3. Other comments
Required by #3183