8000 Improve bpf policies config access by geyslan · Pull Request #3906 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve bpf policies config access #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2024
Merged

Improve bpf policies config access #3906

merged 1 commit into from
Mar 17, 2024

Conversation

geyslan
Copy link
Member
@geyslan geyslan commented Mar 4, 2024 •
edited
Loading

1. Explain what the PR does

f1b2d39 chore: reduce bpf map lookups for policies config

Instead of always retrieving the policies config map version in the
outer and inner maps, create a holder in the event_data and update it
only when config entry version changes.

2. Explain how to test it

3. Other comments

@geyslan geyslan self-assigned this Mar 4, 2024
@geyslan geyslan marked this pull request as ready for review March 4, 2024 20:26
@geyslan

This comment was marked as outdated.

Sign in to view
@geyslan geyslan requested a review from yanivagman March 4, 2024 20:27
@geyslan geyslan force-pushed the the-one-of-policies-version branch from 3aa7e51 to a4c76d2 Compare March 4, 2024 20:27
yanivagman
yanivagman reviewed Mar 10, 2024
View reviewed changes
@geyslan geyslan force-pushed the the-one-of-policies-version branch 2 times, most recently from 975f0d1 to 04bb803 Compare March 10, 2024 15:00
8000 @geyslan geyslan marked this pull request as draft March 14, 2024 13:49
@geyslan geyslan force-pushed the the-one-of-policies-version branch from 04bb803 to a5dc72d Compare March 14, 2024 19:40
@geyslan geyslan marked this pull request as ready for review March 14, 2024 20:14
@geyslan geyslan force-pushed the the-one-of-policies-version branch 2 times, most recently from dfe8512 to 3d58d54 Compare March 14, 2024 21:58
yanivagman
yanivagman reviewed Mar 14, 2024
View reviewed changes
@geyslan geyslan force-pushed the the-one-of-policies-version branch 2 times, most recently from 3c73203 to 128bc68 Compare March 15, 2024 00:08
yanivagman
yanivagman reviewed Mar 15, 2024
View reviewed changes
@geyslan geyslan force-pushed the the-one-of-policies-version branch 2 times, most recently from 4b87acd to f1b2d39 Compare March 15, 2024 09:14
yanivagman
yanivagman reviewed Mar 16, 2024
View reviewed changes
yanivagman
yanivagman approved these changes Mar 16, 2024
View reviewed changes
Copy link
Collaborator
@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan
chore: reduce bpf map lookups for policies config
535da84 
Instead of always retrieving the policies config map version in the
outer and inner maps, create a holder in the event_data and update it
only when config entry version changes.

Also introduces policies_version field in the event_data struct. It is
used to guarantee that task_info.recompute_scope is set to true when
the policies config map version changes.
@geyslan geyslan force-pushed the the-one-of-policies-version branch from f1b2d39 to 535da84 Compare March 17, 2024 15:46
@geyslan geyslan merged commit c6aeee8 into aquasecurity:main Mar 17, 2024
@geyslan geyslan mentioned this pull request Apr 10, 2024
Open
19 tasks
@geyslan geyslan deleted the the-one-of-policies-version branch June 28, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanivagman yanivagman yanivagman approved these changes

Assignees

@geyslan geyslan

Labels
area/ebpf kind/bug kind/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geyslan @yanivagman
0