10000
Update README.md with
Update README.md with permissions keyword where needed
#449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpivkin
reviewed
Mar 12, 2025
| @@ -395,6 +395,9 @@ jobs: | |||
| build: | |||
| name: Build | |||
| runs-on: ubuntu-20.04 | |||
| permissions: | |||
| contents: read # permissions needed to be able to run the checkout action | |||
There was a problem hiding this comment.
Isn't the contents: read permission only needed for private repositories?
There was a problem hiding this comment.
This one was more to always have permissions filled in, to make it explicit and match the other examples.
There was a problem hiding this comment.
I think this should be up to the user to specify. We don't want to grant permissions in the case when it's not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the permissions keyword with correct config in all examples that push the sarif file to the security tab of the repo. With this update, people will have an easier time implementing the examples and prevent strange issues with "Resource not accessible by integration".