8000 ci: use `cargo-release` for publishing by jdygert-spok · Pull Request #52 · aranya-project/aranya · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: use cargo-release for publishing #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 10, 2025
Merged

ci: use cargo-release for publishing #52

merged 9 commits into from
Mar 10, 2025

Conversation

jdygert-spok
Copy link
Contributor
@jdygert-spok jdygert-spok commented Jan 9, 2025

Rather than contorting release-plz to work better for a single version and our workflow, use cargo-release for publishing.

Process:

  1. Obtain the tag version from Cargo.toml with cargo release tag.
  2. Create a release tag with cargo release tag.
  3. Push the tag with cargo release push.
  4. Create a release for the new tag in GitHub.
  5. Build and upload release artifacts to the GitHub release.

If there is an existing tag for the current version in Cargo.toml, the release process will be skipped.

Workflows tested on this fork:
gknopf-aranya#2

@gknopf-aranya
Copy link
Contributor

We can remove the release-plz action and dep forks after this PR is merged

@jdygert-spok
Copy link
Contributor Author

We can remove the release-plz action and dep forks after this PR is merged

I think we will still want to use release-plz for aranya-core.

@gknopf-aranya
Copy link
Contributor

@jdygert-spok is this PR still needed after our release-plz discussions?

@jdygert-spok
Copy link
Contributor Author

Yes, we still want something to do the publishing automatically.

@gknopf-aranya gknopf-aranya mentioned this pull request Mar 5, 2025
68 tasks
@gknopf-aranya gknopf-aranya self-requested a review March 6, 2025 20:51
@gknopf-aranya gknopf-aranya self-assigned this Mar 6, 2025
@gknopf-aranya gknopf-aranya self-requested a review March 6, 2025 22:00
@gknopf-aranya
Copy link
Contributor

For the case where tag creation and crate publishing succeeds, but creating the github release fails, we may want to be able to continue triggering the publish.yml workflow to create a github release separately. A github tag/release can be deleted and recreated, but a Rust crate cannot be republished with the same version.

I originally combined release.yml and publish.yml for simplicity. But I think keeping them separate will give us more flexibility to handle the event when things don't run perfectly during a release.

@gknopf-aranya
Copy link
Contributor

Separated the workflows out again so we can manually trigger publish.yml.

smckeon-so
smckeon-so previously approved these changes Mar 6, 2025
Copy link
Contributor
@smckeon-so smckeon-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nikki-aranya
nikki-aranya previously approved these changes Mar 10, 2025
@gknopf-aranya gknopf-aranya enabled auto-merge (squash) March 10, 2025 17:46
@gknopf-aranya gknopf-aranya merged commit d62b516 into main Mar 10, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0