-
Notifications
You must be signed in to change notification settings - Fork 11
ci: use cargo-release
for publishing
#52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We can remove the |
I think we will still want to use release-plz for aranya-core. |
@jdygert-spok is this PR still needed after our |
Yes, we still want something to do the publishing automatically. |
10a8946
to
e9be838
Compare
For the case where tag creation and crate publishing succeeds, but creating the github release fails, we may want to be able to continue triggering the publish.yml workflow to create a github release separately. A github tag/release can be deleted and recreated, but a Rust crate cannot be republished with the same version. I originally combined release.yml and publish.yml for simplicity. But I think keeping them separate will give us more flexibility to handle the event when things don't run perfectly during a release. |
Separated the workflows out again so we can manually trigger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
c5f0bb0
Rather than contorting
release-plz
to work better for a single version and our workflow, usecargo-release
for publishing.Process:
Cargo.toml
withcargo release tag
.cargo release tag
.cargo release push
.If there is an existing tag for the current version in
Cargo.toml
, the release process will be skipped.Workflows tested on this fork:
gknopf-aranya#2