8000 debug: listen capabilities fix:#317 by Penglq · Pull Request #328 · arana-db/arana · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

debug: listen capabilities fix:#317 #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2022
Merged

Conversation

Penglq
Copy link
Contributor
@Penglq Penglq commented Jul 30, 2022

What this PR does:

Which issue(s) this PR fixes:

Fixes #317

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

Codecov Report

Merging #328 (03dc286) into master (b04366f) will decrease coverage by 0.34%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   39.75%   39.41%   -0.35%     
==========================================
  Files          99      100       +1     
  Lines       13702    13871     +169     
==========================================
+ Hits         5447     5467      +20     
- Misses       7588     7734     +146     
- Partials      667      670       +3     
Impacted Files Coverage Δ
pkg/mysql/conn.go 39.94% <ø> (ø)
pkg/mysql/execute_handle.go 0.00% <0.00%> (ø)
pkg/mysql/server.go 0.00% <0.00%> (ø)
pkg/proto/rule/rule.go 69.14% <0.00%> (-12.11%) ⬇️
pkg/runtime/namespace/namespace.go 53.44% <0.00%> (-1.34%) ⬇️
pkg/boot/discovery.go 64.39% <0.00%> (-0.91%) ⬇️
pkg/runtime/namespace/command.go 26.92% <0.00%> (-0.11%) ⬇️
pkg/config/model.go 28.97% <0.00%> (ø)
pkg/sequence/snowflake/snowflake.go 12.76% <0.00%> (ø)
pkg/boot/boot.go 56.75% <0.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b04366f...03dc286. Read the comment docs.

@dongzl dongzl added the bug Something isn't working label Jul 31, 2022
Copy link
Contributor
@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jjeffcaii jjeffcaii merged commit 9279009 into arana-db:master Jul 31, 2022
binbin0325 pushed a commit to binbin0325/arana that referenced this pull request Jul 31, 2022
* Add: add test case for iterator.

* fix: format import.

* fix: fix test case error.

* Add: add test case for shard_expr.

* Add: add license header.

* Add: add new test case.

* fix: fix import format.

* refactor schemanager cache to lru cache (arana-db#246)

Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>

* optimize maxAllowedPacket config fix: arana-db#292 arana-db#281 (arana-db#297)

* insert multi value at once request, throw error msg when any row error fix: arana-db#287 (arana-db#313)

* feat: support show status (arana-db#309)

* feat: max_allowed_packet is set by the user (arana-db#312)

Co-authored-by: Zonglei Dong <dongzonglei@apache.org>
Co-authored-by: Mulavar <978007503@qq.com>
Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>
Co-authored-by: adair peng <luqiangpeng5945@gmail.com>

* style: fix code style

* ci: fix ci bug

* ci: fix ci bug

* ci: fix ci error

* fix: fix ci bug

* fix: fix runtime.Runtime use

Co-authored-by: Jeffsky <jjeffcaii@outlook.com>
Co-authored-by: Zonglei Dong <dongzonglei@apache.org>
Co-authored-by: Mulavar <978007503@qq.com>
Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>
Co-authored-by: adair peng <luqiangpeng5945@gmail.com>

debug: listen capabilities fix:arana-db#317 (arana-db#328)

feat: support "show collation" SQL statement. (arana-db#307)

chore: add unit test. (arana-db#323)

* Add: add unit test for api.go.

* Add: add license header.

* fix: fix import format.

* fix: refactor mock file directory.

* fix: fix import format.

* fix: fix path name.

* fix: fix test config file content.

* add: add test case for file.go .

* fix: fix import format.

* fix: fix file format.

* fix: fix code review problem.

* fix: fix error test case.

* fix: fix bootstrap test config.

* fix: fix test config data.

commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: write fields error 0: conn 0: Check conn status error
5 participants
0