8000 fix: zadd command override rather than ignore the same member in one times by guozhihao-224 · Pull Request #237 · arana-db/kiwi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: zadd command override rather than ignore the same member in one times #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2025
Merged

fix: zadd command override rather than ignore the same member in one times #237

merged 2 commits into from
Apr 19, 2025

Conversation

guozhihao-224
Copy link
@guozhihao-224 guozhihao-224 commented Apr 9, 2025 •
edited by coderabbitai bot
Loading

fix #236

Summary by CodeRabbit

  • Refactor
    • Improved the handling of duplicate members in sorted sets to retain the last occurrence.
    • Enhanced internal processing for better performance while preserving existing functionality.

fix: When there are multiple identical members in zadd command, only …
1694b38 
…the rightmost member-score pair is written
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Apr 9, 2025 •
edited
Loading

"""

Walkthrough

The pull request updates the ZAdd method in the Redis class located at src/storage/src/redis_zsets.cc. The method now uses an unordered_map to track members and their scores by iterating over the input vector in reverse order, ensuring the last occurrence of each member is kept. This replaces the previous approach that used an unordered_set and kept the first occurrence. The rest of the method and its signature remain unchanged.

Changes

File(s) Change Summary
src/storage/.../redis_zsets.cc Modified the ZAdd method: replaced the unordered_set-based duplicate filtering with an unordered_map that maps members to scores by reverse iteration, keeping the last occurrence of each member.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant R as Redis::ZAdd
    C->>R: Call ZAdd(key, score_members, ret)
    R->>R: Iterate score_members in reverse
    R->>R: Insert member→score into ms_map if new
    R->>R: Append member and score to filtered_score_members
    R-->>C: Return Status and update ret
Loading

Assessment against linked issues

Objective Addressed Explanation
Implement correct duplicate member handling (#236) ✅

Suggested reviewers

  • AlexStocks

Poem

I'm a bunny hopping through the code,
Skipping duplicates on my merry road.
With maps instead of sets at play,
My ZAdd sings a brighter day,
A code garden where bugs erode. 🐇🌷
"""

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1694b38 and d4e90a1.

📒 Files selected for processing (1)
  • src/storage/src/redis_zsets.cc (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/storage/src/redis_zsets.cc
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build_on_macos
  • GitHub Check: build_on_ubuntu
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@marsevilspirit
Copy link
Collaborator
marsevilspirit commented Apr 12, 2025 •
edited
Loading

为什么修改了文件的权限？
image

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.

Why did the file permissions be modified?

marsevilspirit
marsevilspirit reviewed Apr 12, 2025
View reviewed changes
Copy link
Collaborator
@marsevilspirit marsevilspirit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comment

marsevilspirit
marsevilspirit approved these changes Apr 19, 2025
View reviewed changes
Copy link
Collaborator
@marsevilspirit marsevilspirit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlexStocks AlexStocks merged commit 0fa4f1b into arana-db:unstable Apr 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@marsevilspirit marsevilspirit marsevilspirit approved these changes

Assignees
No one assigned
Labels
☢️ Bug ✏️ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZADD命令行为与Redis不一致
4 participants
@guozhihao-224 @marsevilspirit @Issues-translate-bot @AlexStocks
0