8000 Pass GeometryTraits template args through remove_cv by aprokop · Pull Request #1129 · arborx/ArborX · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Pass GeometryTraits template args through remove_cv #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 5, 2024
Merged

Pass GeometryTraits template args through remove_cv #1129

merged 3 commits into from
Aug 5, 2024

Conversation

aprokop
Copy link
Contributor
@aprokop aprokop commented Aug 2, 2024

Currently, code using things like dimension_v<const Point> does not work. This addresses the issue by passing provided template parameter Geometry through std::remove_cv.

Once we start requiring C++20, should probably switch to std::remove_cvref.

dalg24
dalg24 approved these changes Aug 3, 2024
View reviewed changes
Copy link
Contributor
@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cv-qualified sure, reference no way

@aprokop @dalg24
Remove volatile tests (overkill)
081f71a 
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
@aprokop aprokop merged commit 4909851 into arborx:master Aug 5, 2024
1 check passed
@aprokop aprokop deleted the fix_is_blah_v branch August 5, 2024 23:05
@aprokop aprokop mentioned this pull request Aug 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@masterleinad masterleinad masterleinad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aprokop @dalg24 @masterleinad
0