test/e2e: pick correct controller pod for testscript #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conntmpl-go to build DEV_URL using kubectl command
datdao
approved these changes
Oct 9, 2024
luantranminh
approved these changes
Oct 9, 2024
rotemtam
reviewed
Oct 9, 2024
| require.NoError(t, err) | ||
| pods := strings.Split(output, "\n") | ||
| if len(pods) == 1 { | ||
| controllerPod = pods[0] |
There was a problem hiding this comment.
Can this work with kubectl wait?
There was a problem hiding this comment.
No. :( Both old and new pod still in the running state, it cause conflicts then pick the pod in termination process
rotemtam
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.