Feat(eos_designs): Add more feature support toggles for platform_settings. Batch 3 (sFlow) #5603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5603
# Activate the virtual environment
source test-avd-pr-5603/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/alexeygorbunov/avd.git@feature/feature-support-veos-cloudeos-batch-3#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/alexeygorbunov/avd.git#/ansible_collections/arista/avd/,feature/feature-support-veos-cloudeos-batch-3 --force
# Optional: Install AVD examples
cd test-avd-pr-5603
ansible-playbook arista.avd.install_examples |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Enforce platform-based limitations for the following EOS features:
sFlow. Affected AVD eos_designs knobs:
sFlow functionality is not supported on cloudEOS virtual platform.
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designsProposed changes
Disable rendering of sFlow-related structured config unless
shared_utils.platform_settings.feature_support.sflowis TrueHow to test
eos_designs_unit_testsmolecule scenariopytestfor moleculeChecklist
User Checklist
Repository Checklist