8000 Fix(cv_container_v3): check_mode error by sugetha24 · Pull Request #584 · aristanetworks/ansible-cvp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix(cv_container_v3): check_mode error #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2023
Merged

Fix(cv_container_v3): check_mode error #584

merged 1 commit into from
Feb 22, 2023

Conversation

sugetha24
Copy link
Contributor

Change Summary

Running cv_container_v3 with --check is throwing an error:
TypeError: string indices must be integers

Related Issue(s)

Fixes #582

Component(s) name

arista.cvp.cv_container_v3

How to test

---
- name: cv_container_v3
  hosts: CloudVision
  connection: local
  gather_facts: no
  check_mode: True
  vars:
    CVP_CONTAINERS:
      Sugetha:
        parentContainerName: Tenant
      TestCreate:
        parentContainerName: Sugetha

  tasks:
    - name: "Configure containers on {{inventory_hostname}}"
      arista.cvp.cv_container_v3:
        topology: "{{CVP_CONTAINERS}}"
        state: present
        apply_mode: loose

Output:

changed: [CloudVision] => changed=true 
  configlets_attached:
    changed: false
    configlets_attached_count: 0
    configlets_attached_list: []
    diff: {}
    success: false
    taskIds: []
  configlets_detached:
    changed: false
    configlets_detached_count: 0
    configlets_detached_list: []
    diff: {}
    success: true
    taskIds: []
  container_added:
    changed: true
    container_added_count: 1
    container_added_list:
    - TestCreate
    diff: {}
    success: true
    taskIds: []
  container_deleted:
    changed: false
    container_deleted_count: 0
    container_deleted_list: []
    diff: {}
    success: false
    taskIds: []
  success: true
  taskIds: []

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly. (check the box if not applicable)
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@sugetha24 sugetha24 self-assigned this Jan 31, 2023
@github-actions github-actions bot added module: cv_container_v3 Issue related to cv_container module in v3 module_utils: cv_client cv_client implementation issue labels Jan 31, 2023
colinmacgiolla
colinmacgiolla approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor
@colinmacgiolla colinmacgiolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - looks good to me!

@sugetha24 sugetha24 added this to the v3.7.0 milestone Feb 22, 2023
@sugetha24 sugetha24 merged commit ec7bb01 into aristanetworks:devel Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmacgiolla colinmacgiolla colinmacgiolla approved these changes

@gmuloc gmuloc Awaiting requested review from gmuloc

@noredistribution noredistribution Awaiting requested review from noredistribution

@guillaumeVilar guillaumeVilar Awaiting requested review from guillaumeVilar

Assignees

@sugetha24 sugetha24

Labels
module: cv_container_v3 Issue related to cv_container module in v3 module_utils: cv_client cv_client implementation issue
Projects
None yet
Milestone
v3.6.1
Development

Successfully merging this pull request may close these issues.

Fix: Error using --check with cv_container_v3
2 participants
@sugetha24 @colinmacgiolla
0