8000 feat(anta.tests): Adding the test case to verify BGP ECMP paths by MaheshGSLAB · Pull Request #507 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(anta.tests): Adding the test case to verify BGP ECMP paths #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 6, 2025
Merged

feat(anta.tests): Adding the test case to verify BGP ECMP paths #507

merged 10 commits into from
Feb 6, 2025

Conversation

MaheshGSLAB
Copy link
Collaborator
@MaheshGSLAB MaheshGSLAB commented Jan 2, 2024 •
edited by carl-baillargeon
Loading

Description

Adding the test case to verify BGP ECMP path install

Test catalog:

anta.tests.routing:
  bgp:
      - VerifyBGPEcmpPath:
          bgp_routes:
            - route: 192.0.254.5/32
              vrf: default
            - route: 192.0.254.3/32
              vrf: default
  1. Testcase pass if route is contributed into ECMP and at least one path is ECMP head in specified vrf.

                                                                          All tests results                                                                           
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Device    ┃ Test Name         ┃ Test Status ┃ Message(s) ┃ Test description                                                                        ┃ Test category ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ s1-spine1 │ VerifyBGPEcmpPath │ success     │            │ Verifies the installation of BGP Equal-Cost Multipath (ECMP) path in the specified VRF. │ routing, bgp  │
└───────────┴───────────────────┴─────────────┴────────────┴─────────────────────────────────────────────────────────────────────────────────────────┴───────────────┘
  1. Testcase fail if route is not found in the specified vrf.
                                                                                         All tests results                                                                                           
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Device    ┃ Test Name         ┃ Test Status ┃ Message(s)                                                        ┃ Test description                                                 ┃ Test category ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ s1-spine1 │ VerifyBGPEcmpPath │ failure     │ Following BGP routes are not configured, not contributed in ecmp, │ Verifies the installation of BGP Equal-Cost Multipath (ECMP)     │ routing, bgp  │
│           │                   │             │ or ecmp head is not found:                                        │ path in the specified VRF.                                       │               │
│           │                   │             │ {'192.0.254.5/32': {'MGMT': 'Not configured'}}                    │                                                                  │               │
└───────────┴───────────────────┴─────────────┴───────────────────────────────────────────────────────────────────┴──────────────────────────────────────────────────────────────────┴───────────────┘
  1. Testcase fail if route is not contributed in ECMP or ECMP head is not found in the specified vrf.
                                                                                         All tests results                                                                                           
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Device    ┃ Test Name         ┃ Test Status ┃ Message(s)                                                        ┃ Test description                                                 ┃ Test category ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ s1-spine1 │ VerifyBGPEcmpPath │ failure     │ Following BGP routes are not configured, not contributed in ecmp, │ Verifies the installation of BGP Equal-Cost Multipath (ECMP)     │ routing, bgp  │
│           │                   │             │ or ecmp head is not found:                                        │ path in the specified VRF.                                       │               │
│           │                   │             │ {'192.0.255.5/32': {'default': 'ECMP path is not installed'}}     │                                                                  │               │
└───────────┴───────────────────┴─────────────┴───────────────────────────────────────────────────────────────────┴──────────────────────────────────────────────────────────────────┴───────────────┘

Fixes #505

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@MaheshGSLAB MaheshGSLAB self-assigned this Jan 2, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review January 2, 2024 09:07
@MaheshGSLAB MaheshGSLAB changed the title feat: Adding the test case to verify BGP ECMP path install feat(anta.tests)!: Adding the test case to verify BGP ECMP path install Jan 4, 2024
@gmuloc gmuloc changed the title feat(anta.tests)!: Adding the test case to verify BGP ECMP path install feat(anta.tests): Adding the test case to verify BGP ECMP path install Jan 5, 2024
carl-baillargeon
carl-baillargeon requested changes Jan 6, 2024
View reviewed changes
MaheshGSLAB
MaheshGSLAB commented Jan 24, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

carl-baillargeon
carl-baillargeon requested changes Jan 29, 2024
View reviewed changes
Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold on this one. The logic is pretty complex, we might have to split it in 2 test cases.

@MaheshGSLAB MaheshGSLAB changed the title feat(anta.tests): Adding the test case to verify BGP ECMP path install feat(anta.tests): Adding the test case to verify BGP ECMP path install(On Hold) Feb 1, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as draft February 23, 2024 11:29
@carl-baillargeon carl-baillargeon added this to the v1.1.0 milestone Apr 22, 2024
@gmuloc gmuloc modified the milestones: v1.1.0, v1.2.0 Oct 11, 2024
@carl-baillargeon carl-baillargeon modified the milestones: v1.2.0, v1.3.0 Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@carl-baillargeon carl-baillargeon changed the title feat(anta.tests): Adding the test case to verify BGP ECMP path install(On Hold) feat(anta.tests): Adding the test case to verify BGP ECMP paths Jan 22, 2025
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Jan 22, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #507 will not alter performance

Comparing MaheshGSLAB:issue-505 (cfc3059) with main (6df82e7)

Summary

✅ 22 untouched benchmarks

vitthalmagadum
vitthalmagadum requested changes Jan 30, 2025
View reviewed changes
@vitthalmagadum vitthalmagadum marked this pull request as ready for review January 30, 2025 11:35
carl-baillargeon
carl-baillargeon requested changes Feb 2, 2025
View reviewed changes
carl-baillargeon
carl-baillargeon reviewed Feb 3, 2025
View reviewed changes F438
carl-baillargeon
carl-baillargeon reviewed Feb 3, 2025
View reviewed changes
carl-baillargeon
carl-baillargeon reviewed Feb 3, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

carl-baillargeon
carl-baillargeon approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks :)

@carl-baillargeon carl-baillargeon merged commit efef2c9 into aristanetworks:main Feb 6, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@vitthalmagadum vitthalmagadum vitthalmagadum approved these changes

@gmuloc gmuloc Awaiting requested review from gmuloc

Assignees

@geetanjalimanegslab geetanjalimanegslab

Labels
network-tests rn: feat(anta.tests)
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Add the test case to verify the BGP ECMP path install
5 participants
@MaheshGSLAB @carl-baillargeon @vitthalmagadum @gmuloc @geetanjalimanegslab
0