8000 fix(anta.cli): Evaluate nrfu subcommands args before running the tests by gmuloc · Pull Request #707 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(anta.cli): Evaluate nrfu subcommands args before running the tests #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 4, 2024
Merged

fix(anta.cli): Evaluate nrfu subcommands args before running the tests #707

merged 4 commits into from
Jul 4, 2024

Conversation

gmuloc
Copy link
Collaborator
@gmuloc gmuloc commented Jun 11, 2024 •
edited
Loading

Description

Today anta nrfu tpl-report runs the test and then raise when it realises that the template file is missing
Thats not what is intended

Fixes field reported issue

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gmuloc gmuloc added this to the v1.1.0 milestone Jun 12, 2024
@gmuloc gmuloc changed the title Fix(anta.cli): Evaluate nrfu subcommands args before running the tests fix(anta.cli): Evaluate nrfu subcommands args before running the tests Jun 20, 2024
carl-baillargeon
carl-baillargeon approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally:
image

@carl-baillargeon carl-baillargeon merged commit 0f88b28 into aristanetworks:main Jul 4, 2024
17 checks passed
@gmuloc gmuloc deleted the check-nrfu-subcommand-before-run branch January 15, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@gmuloc gmuloc

Labels
rn: fix(anta.cli)
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gmuloc @carl-baillargeon
0