8000 doc: Adjust Args to Parameters to comply with numpy by gmuloc · Pull Request #724 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

doc: Adjust Args to Parameters to comply with numpy #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2024
Merged

doc: Adjust Args to Parameters to comply with numpy #724

merged 3 commits into from
Jul 4, 2024

Conversation

gmuloc
Copy link
Collaborator
@gmuloc gmuloc commented Jun 20, 2024

Description

cf tilte

Fixes #723

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc changed the title Doc: Adjust Args to Parameters to comply with numpy doc: Adjust Args to Parameters to comply with numpy Jun 20, 2024
@gmuloc gmuloc requested a review from carl-baillargeon June 20, 2024 14:02
@gmuloc gmuloc added this to the v1.1.0 milestone Jun 20, 2024
carl-baillargeon
carl-baillargeon reviewed Jun 28, 2024
View reviewed changes
@gmuloc gmuloc requested a review from carl-baillargeon July 4, 2024 09:11
carl-baillargeon
carl-baillargeon approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-baillargeon carl-baillargeon merged commit e9aff4a into aristanetworks:main Jul 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@gmuloc gmuloc

Labels
rn: doc
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Docstrings
2 participants
@gmuloc @carl-baillargeon
0