8000 feat(anta): Refactor VerifyReachability test case to add coverage for DF Bit, packet size by vitthalmagadum · Pull Request #761 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(anta): Refactor VerifyReachability test case to add coverage for DF Bit, packet size #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2024
Merged

feat(anta): Refactor VerifyReachability test case to add coverage for DF Bit, packet size #761

merged 2 commits into from
Aug 8, 2024

Conversation

vitthalmagadum
Copy link
Collaborator

Description

  • Updated the test case to include optional field of DF bit(Updated input model for df-bit) in command.
  • Included optional field of packet size variation(Updated input model for packet size) in command.

Fixes #756

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@vitthalmagadum vitthalmagadum marked this pull request as draft July 22, 2024 07:06
MaheshGSLAB
MaheshGSLAB approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator
@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

carl-baillargeon
carl-baillargeon reviewed Aug 7, 2024
View reviewed changes
carl-baillargeon
carl-baillargeon reviewed Aug 7, 2024
View reviewed changes
carl-baillargeon
carl-baillargeon reviewed Aug 7, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Aug 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vitthalmagadum vitthalmagadum marked this pull request as ready for review August 8, 2024 10:59
carl-baillargeon
carl-baillargeon approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-baillargeon carl-baillargeon merged commit f525ffb into aristanetworks:main Aug 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: feat(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor VerifyReachability test case to add coverage for DF Bit, packet size
3 participants
@vitthalmagadum @carl-baillargeon @MaheshGSLAB
0