8000 feat(anta): Added the test case to verify the BGP route origin by vitthalmagadum · Pull Request #813 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(anta): Added the test case to verify the BGP route origin #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jan 15, 2025
Merged

feat(anta): Added the test case to verify the BGP route origin #813

merged 22 commits into from
Jan 15, 2025

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Verifies BGP route origin for the provided IPv4 Network(s).

Expected Results
----------------
* Success: The test will pass if the BGP route's origin matches expected origin type.
* Failure: The test will fail if the BGP route's origin does not matches with expected origin type or BGP route entry(s) not found.

Fixes #811

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

MaheshGSLAB
MaheshGSLAB reviewed Sep 17, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

MaheshGSLAB
MaheshGSLAB reviewed Sep 24, 2024
View reviewed changes
@vitthalmagadum
Copy link
Collaborator Author

Added pylint disable for no of line check (C0302) with TODO.
Thanks!!!

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

MaheshGSLAB
MaheshGSLAB reviewed Sep 30, 2024
View reviewed changes
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Oct 1, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #813 will not alter performance

Comparing vitthalmagadum:issue_811 (5478535) with main (ba15a4a)

Summary

✅ 22 untouched benchmarks

@vitthalmagadum vitthalmagadum marked this pull request as ready for review December 19, 2024 12:12
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 2, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 9, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

carl-baillargeon
carl-baillargeon requested changes Jan 14, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

carl-baillargeon
carl-baillargeon approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Vitthal!

@carl-baillargeon carl-baillargeon merged commit 8a61230 into aristanetworks:main Jan 15, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@MaheshGSLAB MaheshGSLAB Awaiting requested review from MaheshGSLAB

@gmuloc gmuloc Awaiting requested review from gmuloc

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: feat(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test case to verify the BGP route origin.
4 participants
@vitthalmagadum @gmuloc @carl-baillargeon @MaheshGSLAB
0