8000 feat(anta): Added VerifyIPv4RouteNextHops test case to verify IPv4 route next-hops by vitthalmagadum · Pull Request #835 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(anta): Added VerifyIPv4RouteNextHops test case to verify IPv4 route next-hops #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jan 29, 2025
Merged

feat(anta): Added VerifyIPv4RouteNextHops test case to verify IPv4 route next-hops #835

merged 19 commits into from
Jan 29, 2025

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Verifies the route entries of given IPv4 network(s).

Supports `strict: True` to verify that only the specified nexthops by which routes are learned, requiring an exact match.

Expected Results
----------------
* Success: The test will pass if the route entry with given nexthop(s) present for given network(s).
* Failure: The test will fail if the routes not found or route entry with given nexthop(s) not present for given network(s).

Fixes #819

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Oct 1, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #835 will not alter performance

Comparing vitthalmagadum:issue_819 (2e244ec) with main (1dd5a60)

Summary

✅ 22 untouched benchmarks

@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

MaheshGSLAB
MaheshGSLAB reviewed Oct 16, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Dec 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@vitthalmagadum vitthalmagadum marked this pull request as draft January 14, 2025 13:44
@vitthalmagadum vitthalmagadum marked this pull request as ready for review January 16, 2025 05:58
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

carl-baillargeon
carl-baillargeon requested changes Jan 20, 2025
View reviewed changes
gmuloc
gmuloc requested changes Jan 21, 2025
View reviewed changes
@vitthalmagadum vitthalmagadum requested a review from gmuloc January 22, 2025 03:05
carl-baillargeon
carl-baillargeon approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmuloc gmuloc changed the title feat(anta): Added the test case to verify multiple routes with only specific nodes as next-hops feat(anta): Added VerifyIPv4RouteNextHops test case to verify IPv4 route next-hops Jan 28, 2025
gmuloc
gmuloc reviewed Jan 28, 2025
View reviewed changes
gmuloc
gmuloc requested changes Jan 28, 2025
View reviewed changes
@vitthalmagadum vitthalmagadum requested a review from gmuloc January 29, 2025 04:14
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gmuloc gmuloc merged commit 08f4a3d into aristanetworks:main Jan 29, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaheshGSLAB MaheshGSLAB MaheshGSLAB left review comments

@gmuloc gmuloc gmuloc approved these changes

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: feat(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the test case to verify multiple routes with only specific nodes as next-hops
4 participants
@vitthalmagadum @gmuloc @carl-baillargeon @MaheshGSLAB
0