8000 feat(anta.cli): Add anta get tests by gmuloc · Pull Request #843 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(anta.cli): Add anta get tests #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 61 commits into from
Dec 2, 2024
Merged

Conversation

gmuloc
Copy link
Collaborator
@gmuloc gmuloc commented Sep 30, 2024

Description

Fixes #326

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc changed the title Feat(anta.cli): Add anta get tests feat(anta.cli): Add anta get tests Sep 30, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@gmuloc gmuloc added this to the v1.2.0 milestone Oct 21, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
codspeed-hq bot commented Oct 29, 2024

CodSpeed Performance Report

Merging #843 will not alter performance

Comparing gmuloc:anta-get-tests (74aba09) with main (d2c8218)

Summary

✅ 8 untouched benchmarks

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions for documentation, otherwise LGTM. Tested locally.

Copy link
sonarqubecloud bot commented Dec 2, 2024

@gmuloc gmuloc merged commit 433b7f2 into aristanetworks:main Dec 2, 2024
24 checks passed
@gmuloc gmuloc deleted the anta-get-tests branch January 15, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Developm 3E79 ent

Successfully merging this pull request may close these issues.

Implement anta get tests to generate a test catalog example
2 participants
0