8000 feat(anta): Added the test case to verify the SNMP source interface for specified VRF by vitthalmagadum · Pull Request #870 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(anta): Added the test case to verify the SNMP source interface for specified VRF #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 21, 2025
Merged

feat(anta): Added the test case to verify the SNMP source interface for specified VRF #870

merged 8 commits into from
Jan 21, 2025

Conversation

vitthalmagadum
Copy link
Collaborator
@vitthalmagadum vitthalmagadum commented Oct 10, 2024 •
edited by carl-baillargeon
Loading

Description

Verifies SNMP source-interface for a specified VRF.

Expected Results
----------------
* Success: The test will pass if the provided SNMP source-interface is configured in the specified VRF.
* Failure: The test will fail if the provided SNMP source-interface is NOT configured in the specified VRF.

Fixes #854

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Oct 10, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #870 will not alter performance

Comparing vitthalmagadum:issue_854 (a15cc3d) with main (e0545a8)

Summary

✅ 22 untouched benchmarks

MaheshGSLAB
MaheshGSLAB reviewed Oct 11, 2024
View reviewed changes
MaheshGSLAB
MaheshGSLAB reviewed Oct 11, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Dec 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

carl-baillargeon
carl-baillargeon approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when CI passes.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@carl-baillargeon carl-baillargeon merged commit 995943a into aristanetworks:main Jan 21, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@MaheshGSLAB MaheshGSLAB Awaiting requested review from MaheshGSLAB

Assignees

@geetanjalimanegslab geetanjalimanegslab

Labels
rn: feat(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the test case to verify the SNMP source interface for specified VRF
4 participants
@vitthalmagadum @carl-baillargeon @MaheshGSLAB @geetanjalimanegslab
0