8000 feat(anta): Management cvx enabled by sarunac · Pull Request #896 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(anta): Management cvx enabled #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 28, 2024
Merged

feat(anta): Management cvx enabled #896

merged 6 commits into from
Oct 28, 2024

Conversation

sarunac
Copy link
Contributor
@sarunac sarunac commented Oct 23, 2024 •
edited
Loading

Description

Anta Tests to verify if Management CVX is enabled or not.
Fixes # (issue id)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@sarunac sarunac changed the title Management cvx enabled feat(anta): Management cvx enabled Oct 23, 2024
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Oct 23, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #896 will not alter performance

Comparing sarunac:managementCVXEnabled (d3225cb) with main (a76ae07)

Summary

✅ 8 untouched benchmarks

gmuloc
gmuloc reviewed Oct 23, 2024
View reviewed changes
Copy link
Collaborator
@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

I know it is not documented but if you can add the example of your test in the examples/tests.yml that would be great (soon to be automated hopefully)

carl-baillargeon
carl-baillargeon reviewed Oct 28, 2024
View reviewed changes
carl-baillargeon
carl-baillargeon reviewed Oct 28, 2024
View reviewed changes
carl-baillargeon
carl-baillargeon reviewed Oct 28, 2024
View reviewed changes
carl-baillargeon
carl-baillargeon reviewed Oct 28, 2024
View reviewed changes
carl-baillargeon
carl-baillargeon reviewed Oct 28, 2024
View reviewed changes
carl-baillargeon
carl-baillargeon reviewed Oct 28, 2024
View reviewed changes
carl-baillargeon
carl-baillargeon reviewed Oct 28, 2024
View reviewed changes
carl-baillargeon and others added 2 commits October 28, 2024 16:08
@carl-baillargeon @gmuloc
Apply suggestions from code review
01bf13d 
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@carl-baillargeon
Merge branch 'main' into managementCVXEnabled
d3225cb
carl-baillargeon
carl-baillargeon approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @sarunac

@carl-baillargeon carl-baillargeon merged commit fe94dfb into aristanetworks:main Oct 28, 2024
12 of 13 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc left review comments

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@sarunac sarunac

Labels
rn: feat(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarunac @gmuloc @carl-baillargeon
0