8000 fix(anta.cli): Print multiple messages for anta nrfu text by gmuloc · Pull Request #897 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(anta.cli): Print multiple messages for anta nrfu text #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix(anta.cli): Print multiple messages for anta nrfu text #897

merged 1 commit into from
Oct 24, 2024

Conversation

gmuloc
Copy link
Collaborator
@gmuloc gmuloc commented Oct 23, 2024

Description

Print multiple messages in text output when present

leaf1 :: VerifyInterfacesSpeed :: FAILURE
    Interface `Ethernet2` is not found.
    Interface `Ethernet3` is not found.
    Interface `Ethernet4` is not found.

Fixes #895

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Oct 23, 2024

CodSpeed Performance Report

Merging #897 will not alter performance

Comparing gmuloc:issue/895 (bf3591c) with main (a8aeb44)

Summary

✅ 8 untouched benchmarks

vitthalmagadum
vitthalmagadum approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator
@vitthalmagadum vitthalmagadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

carl-baillargeon
carl-baillargeon approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-baillargeon carl-baillargeon merged commit a76ae07 into aristanetworks:main Oct 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
67B9
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@vitthalmagadum vitthalmagadum vitthalmagadum approved these changes

Assignees

@gmuloc gmuloc

Labels
rn: fix(anta.cli)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix(anta): ANTA's Command-Line Interface (CLI): nrfu text command prints the partial test results
3 participants
@gmuloc @carl-baillargeon @vitthalmagadum
0