8000 fix(anta.tests): Fix wrong type used for inputs for VerifyInterfaceIPv4 by gmuloc · Pull Request #977 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(anta.tests): Fix wrong type used for inputs for VerifyInterfaceIPv4 #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2024
Merged

fix(anta.tests): Fix wrong type used for inputs for VerifyInterfaceIPv4 #977

merged 1 commit into from
Dec 24, 2024

Conversation

gmuloc
Copy link
Collaborator
@gmuloc gmuloc commented Dec 23, 2024

Description

Use correct type for inputs

Fixes #973

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc mentioned this pull request Dec 23, 2024
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #977 will not alter performance

Comparing gmuloc:issue/973 (1d5d33f) with main (5afc61d)

Summary

✅ 22 untouched benchmarks

@gmuloc gmuloc 8000 added this to the v1.2.0 milestone Dec 23, 2024
carl-baillargeon
carl-baillargeon approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-baillargeon carl-baillargeon merged commit 4e13729 into aristanetworks:main Dec 24, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@gmuloc gmuloc

Labels
rn: fix(anta.tests)
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

bug: VerifyInterfaceIPv4 seems to use wrong type for IPv4 Addresses
2 participants
@gmuloc @carl-baillargeon
0