10000 refactor(anta.tests): Nicer result failure messages STP and System test module  by geetanjalimanegslab · Pull Request #1043 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(anta.tests): Nicer result failure messages STP and System test module  #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2025
Merged

refactor(anta.tests): Nicer result failure messages STP and System test module  #1043

merged 4 commits into from
Feb 25, 2025

Conversation

geetanjalimanegslab
Copy link
Collaborator
@geetanjalimanegslab geetanjalimanegslab commented Feb 14, 2025 •
edited
Loading

Nicer result failure messages for following test module.

  1. STP
  2. System

Fixes #587

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Feb 14, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1043 will not alter performance

Comparing geetanjalimanegslab:fix_stp_system_module_failure_msg (9f6e4c1) with main (7c9bef4)

Summary

✅ 22 untouched benchmarks

@geetanjalimanegslab geetanjalimanegslab mentioned this pull request Feb 14, 2025
Closed
@geetanjalimanegslab geetanjalimanegslab force-pushed the fix_stp_system_module_failure_msg branch from fba8ab7 to 2292c59 Compare February 18, 2025 06:09
@geetanjalimanegslab geetanjalimanegslab marked this pull request as ready for review February 20, 2025 14:18
carl-baillargeon
carl-baillargeon reviewed Feb 20, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

carl-baillargeon
carl-baillargeon approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carl-baillargeon carl-baillargeon merged commit 91dea1a into aristanetworks:main Feb 25, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@vitthalmagadum vitthalmagadum vitthalmagadum approved these changes

Assignees

@geetanjalimanegslab geetanjalimanegslab

Labels
rn: refactor(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have nicer result failure messages
3 participants
@geetanjalimanegslab @carl-baillargeon @vitthalmagadum
0