8000 feat(anta.tests): Added negative testing in VerifyReachability test by vitthalmagadum · Pull Request #1053 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(anta.tests): Added negative testing in VerifyReachability test #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2025
Merged

feat(anta.tests): Added negative testing in VerifyReachability test #1053

merged 4 commits into from
Feb 25, 2025

Conversation

vitthalmagadum
Copy link
Collaborator
@vitthalmagadum vitthalmagadum commented Feb 21, 2025 •
edited
Loading

Description

Added Negative testing in VerifyReachability

Added reachable: bool = True to the input model, Indicates whether the destination should be reachable. Set to True if the network should be accessible, False otherwise.
Validated with the unit tests.

Fixes #1047

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Feb 21, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1053 will not alter performance

Comparing vitthalmagadum:issue_1047_reachability (3bb9245) with main (45f3b5b)

Summary

✅ 22 untouched benchmarks

geetanjalimanegslab
geetanjalimanegslab approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator
@geetanjalimanegslab geetanjalimanegslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

carl-baillargeon
carl-baillargeon reviewed Feb 21, 2025
View reviewed changes
@vitthalmagadum vitthalmagadum force-pushed the issue_1047_reachability branch from 8bb21eb to cfabf8d Compare February 25, 2025 10:36
carl-baillargeon
carl-baillargeon reviewed Feb 25, 2025
View reviewed changes
carl-baillargeon
carl-baillargeon approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@carl-baillargeon carl-baillargeon merged commit 5d68bd6 into aristanetworks:main Feb 25, 2025
24 of 25 checks passed
@carl-baillargeon carl-baillargeon mentioned this pull request Feb 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@geetanjalimanegslab geetanjalimanegslab geetanjalimanegslab approved these changes

@gmuloc gmuloc Awaiting requested review from gmuloc

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: feat(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: negative testing in VerifyReachability
4 participants
@vitthalmagadum @gmuloc @carl-baillargeon @geetanjalimanegslab
0