8000 feat(anta.tests): Added support for NTP pool in VerifyNTPAssociations test by vitthalmagadum · Pull Request #1068 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(anta.tests): Added support for NTP pool in VerifyNTPAssociations test #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Added support for NTP pool in VerifyNTPAssociations test

Fixes #1054

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link
codspeed-hq bot commented Mar 7, 2025

CodSpeed Performance Report

Merging #1068 will not alter performance

Comparing vitthalmagadum:issue_1054_ntp_asociation (3a77b25) with main (99e9150)

Summary

✅ 22 untouched benchmarks

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@vitthalmagadum vitthalmagadum force-pushed the issue_1054_ntp_asociation branch from d4523b2 to 954d122 Compare March 11, 2025 09:31
@carl-baillargeon carl-baillargeon added this to the v1.3.0 milestone Mar 11, 2025
67ED Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when example is updated + type annotations.

@vitthalmagadum vitthalmagadum force-pushed the issue_1054_ntp_asociation branch from 7b20c22 to 9a52a55 Compare March 12, 2025 13:19
Copy link

@carl-baillargeon carl-baillargeon merged commit 4d8506a into aristanetworks:main Mar 12, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(anta.systems) : VerifyNTPAssociations returns error
4 participants
0