8000 feat(anta.tests): Extend VerifyBGPPeerSession, VerifyBGPPeerSessionRibd, VerifyBGPPeersHealth and VerifyBGPSpecificPeers test to also checks for a minimum established time for BGP session by vitthalmagadum · Pull Request #1063 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(anta.tests): Extend VerifyBGPPeerSession, VerifyBGPPeerSessionRibd, VerifyBGPPeersHealth and VerifyBGPSpecificPeers test to also checks for a minimum established time for BGP session #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2025

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Extend VerifyBGPPeerSession, VerifyBGPPeerSessionRibd, VerifyBGPPeersHealth and VerifyBGPSpecificPeers test to also checks for a minimum established time for BGP session

Fixes #635

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link
codspeed-hq bot commented Mar 5, 2025

CodSpeed Performance Report

Merging #1063 will not alter performance

Comparing vitthalmagadum:issue_635 (486dcb7) with main (5dcb9fc)

Summary

✅ 22 untouched benchmarks

Copy link
Collaborator
@geetanjalimanegslab geetanjalimanegslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carl-baillargeon carl-baillargeon added this to the v1.3.0 milestone Mar 11, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

Copy link
Contributor
@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@carl-baillargeon carl-baillargeon merged commit 99e9150 into aristanetworks:main Mar 12, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend VerifyBGPPeerCount or VerifyBGPPeersHealth test to also checks for a minimum established time for BGP session
3 participants
0