8000 feat(anta): Added fix for Markdown report generation should permit custom sections in the constructor by geetanjalimanegslab · Pull Request #1071 · aristanetworks/anta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(anta): Added fix for Markdown report generation should permit custom sections in the constructor #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

feat(anta): Added fix for Markdown report generation should permit custom sections in the constructor #1071

wants to merge 8 commits into from

Conversation

geetanjalimanegslab
Copy link
Collaborator
@geetanjalimanegslab geetanjalimanegslab commented Mar 7, 2025 •
edited
Loading

Description

Added support for custom section of failed result summary in the markdown report.

Fixes #1062

Here is the makrdown report after adding the fix:

  1. When the testsuites are having failures:
    report.md

  2. When their is no failure detected in the testsuites.
    report.md

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Mar 7, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1071 will degrade performances by 40.71%

Comparing geetanjalimanegslab:issue_1062_fix_markdown_report (ddb7203) with main (2ba75e4)

Summary

❌ 2 regressions
✅ 20 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ test_markdown[1-device] 10.3 ms 17 ms -39.55%
❌ test_markdown[2-devices] 19.8 ms 33.4 ms -40.71%

@carl-baillargeon carl-baillargeon added this to the v.1.4.0 milestone Mar 11, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@geetanjalimanegslab
Copy link
Collaborator Author

Closing this PR as the same change is handled in #1122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitthalmagadum vitthalmagadum Awaiting requested review from vitthalmagadum

Assignees

@geetanjalimanegslab geetanjalimanegslab

Labels
None yet
Projects
None yet
Milestone
v.1.4.0
Development

Successfully merging this pull request may close these issues.

Markdown report generation should permit custom sections in the constructor
2 participants
@geetanjalimanegslab @carl-baillargeon
0